YGNodeFree: mark parent dirty when child is freed#57129
Open
cipolleschi wants to merge 1 commit into
Open
Conversation
Summary: fixes react/yoga#1659. **problem:** `YGNodeFree` called `owner->removeChild(node)` to detach the node from its parent, but never called `owner->markDirtyAndPropagate()`. the parent's layout stayed stale after the free, so a subsequent `YGNodeCalculateLayout` wouldn't recompute it. `YGNodeRemoveChild` has always called `markDirtyAndPropagate` — `YGNodeFree` was just missing the same call. `YGNodeFreeRecursive` was already correct for its recursive child removals (it calls `YGNodeRemoveChild` internally), but the terminal `YGNodeFree(root)` inherited the bug. **fix:** added `owner->markDirtyAndPropagate()` after `node->setOwner(nullptr)` in `YGNodeFree`. regression tests: `dirty_parent_when_child_freed` and `dirty_parent_when_subtree_freed_recursive` in `YGDirtyMarkingTest.cpp`. bypass-github-export-checks X-link: react/yoga#1969 Reviewed By: javache Differential Revision: D107895988 Pulled By: cipolleschi
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107895988. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
fixes react/yoga#1659.
problem:
YGNodeFreecalledowner->removeChild(node)to detach the node from itsparent, but never called
owner->markDirtyAndPropagate(). the parent's layout stayedstale after the free, so a subsequent
YGNodeCalculateLayoutwouldn't recompute it.YGNodeRemoveChildhas always calledmarkDirtyAndPropagate—YGNodeFreewas justmissing the same call.
YGNodeFreeRecursivewas already correct for its recursive child removals (it callsYGNodeRemoveChildinternally), but the terminalYGNodeFree(root)inherited the bug.fix: added
owner->markDirtyAndPropagate()afternode->setOwner(nullptr)inYGNodeFree.regression tests:
dirty_parent_when_child_freedanddirty_parent_when_subtree_freed_recursivein
YGDirtyMarkingTest.cpp.bypass-github-export-checks
X-link: react/yoga#1969
Reviewed By: javache
Differential Revision: D107895988
Pulled By: cipolleschi